Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated project dependencies #382

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Updated project dependencies #382

merged 2 commits into from
Oct 5, 2023

Conversation

spoenemann
Copy link
Contributor

In preparation of v1.0.0

@spoenemann spoenemann added this to the v1.0.0 milestone Oct 2, 2023
tortmayr
tortmayr requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general. Everything still works as expected.
I only noticed I minor inconsistency between the inversify peer/dependency definitions.

examples/package.json Show resolved Hide resolved
tortmayr
tortmayr approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spoenemann spoenemann merged commit 25ffc24 into master Oct 5, 2023
3 checks passed
@spoenemann spoenemann deleted the dependencies-update branch October 5, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tortmayr tortmayr tortmayr approved these changes

@dhuebner dhuebner Awaiting requested review from dhuebner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@spoenemann @tortmayr