Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed jsdom dependency and test-helper.ts #397

Conversation

gfontorbe
Copy link
Contributor

Solves #390

Removed dependency to jsdom due to licensing issues.

The dependency was only used in test-helper.ts which is not used anymore, so this file also got deleted.

Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
@dhuebner
Copy link
Contributor

dhuebner commented Nov 6, 2023

@gfontorbe
It seems like test-helper.ts is still referenced in tests. I'm getting this error when running tests:


Error: Cannot find module '../utils/test-helper'
Require stack:
- /workspace/sprotty/packages/sprotty/src/lib/virtualize.spec.ts
- /workspace/sprotty/node_modules/mocha/lib/nodejs/esm-utils.js
- /workspace/sprotty/node_modules/mocha/lib/mocha.js
- /workspace/sprotty/node_modules/mocha/lib/cli/one-and-dones.js
- /workspace/sprotty/node_modules/mocha/lib/cli/options.js
- /workspace/sprotty/node_modules/mocha/bin/mocha.js

Also when searching for test-helper I found some references in configuration files.

Copy link
Contributor

@dhuebner dhuebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some test-helper references still exists in package.json and tsconfig.json. Tests are failing.

@gfontorbe gfontorbe closed this Nov 6, 2023
@gfontorbe gfontorbe deleted the gfontorbe/remove-jsdom-and-test-helper branch November 6, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants