Fix Junction points post processor #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
|
@gfontorbe I have tested your changes locally. Junction points are part of the exported SVG and do not remain in diagram. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #451
The Junction point postprocessor was too greedy in selecting junction points groups from the DOM. It would also include groups from the hidden model, creating an issue with junction points disappearing when exporting the diagram to svg.
Now the postprocessor is also triggered on the hidden model, and the selectors are adapted to the hidden or base div.
During the first render (when a new model is set) the moved junction points are removed from the DOM.