Skip to content

Commit

Permalink
Address git commit textarea and git clone bugs
Browse files Browse the repository at this point in the history
Fixes #3544
Fixes #3543

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
  • Loading branch information
vince-fugnitto committed Nov 19, 2018
1 parent 3749764 commit bcacb64
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions packages/git/src/browser/git-view-contribution.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import { GitWidget } from './git-widget';
import { GitRepositoryTracker } from './git-repository-tracker';
import { GitQuickOpenService } from './git-quick-open-service';
import { GitSyncService } from './git-sync-service';
import { WorkspaceService } from '@theia/workspace/lib/browser';

export const GIT_WIDGET_FACTORY_ID = 'git';

Expand Down Expand Up @@ -102,6 +103,7 @@ export class GitViewContribution extends AbstractViewContribution<GitWidget>
@inject(GitQuickOpenService) protected readonly quickOpenService: GitQuickOpenService;
@inject(GitRepositoryTracker) protected readonly repositoryTracker: GitRepositoryTracker;
@inject(GitSyncService) protected readonly syncService: GitSyncService;
@inject(WorkspaceService) protected readonly workspaceService: WorkspaceService;

constructor() {
super({
Expand Down Expand Up @@ -261,6 +263,7 @@ export class GitViewContribution extends AbstractViewContribution<GitWidget>
isVisible: () => this.syncService.canPublish()
});
registry.registerCommand(GIT_COMMANDS.CLONE, {
isEnabled: () => !!this.workspaceService.tryGetRoots().length,
// tslint:disable-next-line:no-any
execute: (args: any[]) => {
let url: string | undefined = undefined;
Expand Down
2 changes: 1 addition & 1 deletion packages/git/src/browser/style/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
.theia-git:focus, .theia-git :focus {
outline: 0;
box-shadow: none;
border: none;
border: 1px solid var(--theia-border-color0);
}

#theia-gitContainer .flexcontainer {
Expand Down

0 comments on commit bcacb64

Please sign in to comment.