Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CustomDocumentOpenContext #10005

Closed
Tracked by #9863
tsmaeder opened this issue Aug 31, 2021 · 3 comments · Fixed by #10784
Closed
Tracked by #9863

Implement CustomDocumentOpenContext #10005

tsmaeder opened this issue Aug 31, 2021 · 3 comments · Fixed by #10784
Labels
custom-editor issues related to custom-editor functionality good first issue good first issues for new contributors vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Aug 31, 2021 •
edited
Loading

Feature Description:

Implement the functionality in CustomDocumentOpenContext. While we already have the backupId field defined, Theia is never passing it to any CustomEditorProvider, since we never call backupCustomDocument(). The untitledDocumentData field is not present in theia.d.ts, but since it's optional in VS Code, any plugin written against vscode.dt.ts will work anyway.
@tsmaeder tsmaeder added vscode issues related to VSCode compatibility custom-editor issues related to custom-editor functionality labels Aug 31, 2021
@tsmaeder
Copy link
Contributor Author

To achieve source compatibility, it would be enough to just declare the field in theia.d.ts.

@tsmaeder tsmaeder mentioned this issue Aug 31, 2021
Closed
48 tasks
@tsmaeder tsmaeder added the good first issue good first issues for new contributors label Aug 31, 2021
@vince-fugnitto
Copy link
Member

@tsmaeder what should the scope be for initial support of the feature? If we are to add support for custom-editor backups it'd be quite involving, especially for a beginner (good first issue label).

@tsmaeder
Copy link
Contributor Author

To achieve source compatibility, it would be enough to just declare the field in theia.d.ts

No real implementation needed.

@tsmaeder tsmaeder added the hackathon issues reserved for hackatons label Jan 10, 2022
@tsmaeder tsmaeder self-assigned this Jan 10, 2022
planger added a commit to eclipsesource/theia that referenced this issue Feb 22, 2022
@planger
Add missing property to CustomDocumentOpenContext
bebe882 
VSCode defines the optional property `untitledDocumentData` in
`CustomDocumentOpenContext`. In theia.d.ts, this property is however
missing. As it is optional and is not used from the main implementation,
this change is merely achieving source compatibility, but prepares its
usage in the ext implementation of the plugin API.

Contributed on behalf of STMicroelectronics

Signed-off-by: Philip Langer <planger@eclipsesource.com>

Fixes eclipse-theia#10005

Change-Id: I8d06335c5621d412e61c97f097d89f5b5bd7279b
@planger planger mentioned this issue Feb 22, 2022
Merged
1 task
planger added a commit to eclipsesource/theia that referenced this issue Feb 22, 2022
@planger
Add missing property to CustomDocumentOpenContext
fde9b0f 
VSCode defines the optional property `untitledDocumentData` in
`CustomDocumentOpenContext`. In theia.d.ts, this property is however
missing. As it is optional and is not used from the main implementation,
this change is merely achieving source compatibility, but prepares its
usage in the ext implementation of the plugin API.

Contributed on behalf of STMicroelectronics

Signed-off-by: Philip Langer <planger@eclipsesource.com>

Fixes eclipse-theia#10005

Change-Id: I8d06335c5621d412e61c97f097d89f5b5bd7279b
planger added a commit to eclipsesource/theia that referenced this issue Feb 22, 2022
@planger
Add missing property to CustomDocumentOpenContext
437d657 
VSCode defines the optional property `untitledDocumentData` in
`CustomDocumentOpenContext`. In theia.d.ts, this property is however
missing. As it is optional and is not used from the main implementation,
this change is merely achieving source compatibility, but prepares its
usage in the ext implementation of the plugin API.

Contributed on behalf of STMicroelectronics

Signed-off-by: Philip Langer <planger@eclipsesource.com>

Fixes eclipse-theia#10005

Change-Id: I1b4d67b5b11fa2c94a8590aac6b8ad0f040cee94
@JonasHelming JonasHelming removed the hackathon issues reserved for hackatons label Feb 22, 2022
msujew pushed a commit that referenced this issue Feb 23, 2022
@planger
Add missing property to CustomDocumentOpenContext (#10784)
48cbd18 
VSCode defines the optional property `untitledDocumentData` in
`CustomDocumentOpenContext`. In theia.d.ts, this property is however
missing. As it is optional and is not used from the main implementation,
this change is merely achieving source compatibility, but prepares its
usage in the ext implementation of the plugin API.

Contributed on behalf of STMicroelectronics

Signed-off-by: Philip Langer <planger@eclipsesource.com>

Fixes #10005

Change-Id: I1b4d67b5b11fa2c94a8590aac6b8ad0f040cee94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
custom-editor issues related to custom-editor functionality good first issue good first issues for new contributors vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing property to CustomDocumentOpenContext eclipsesource/theia
3 participants
@JonasHelming @tsmaeder @vince-fugnitto