Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] Support optional property isTransient in TerminalOptions and ExtensionTerminalOptions #11777

Closed
1 task
Tracked by #11779
rschnekenbu opened this issue Oct 17, 2022 · 1 comment · Fixed by #12055
Closed
1 task
Tracked by #11779

[vscode] Support optional property isTransient in TerminalOptions and ExtensionTerminalOptions #11777

rschnekenbu opened this issue Oct 17, 2022 · 1 comment · Fixed by #12055
Assignees
@lucas-koehler
Labels
terminal issues related to the terminal vscode issues related to VSCode compatibility

Comments

@rschnekenbu
Copy link
Contributor

The type TerminalOptions and ExtensionTerminalOptions miss the optional property:

  • isTransient: Opt-out of the default terminal persistence on restart and reload. This will only take effect when terminal.integrated.enablePersistentSessions is enabled.
@rschnekenbu rschnekenbu mentioned this issue Oct 17, 2022
Closed
6 tasks
@vince-fugnitto vince-fugnitto added terminal issues related to the terminal vscode issues related to VSCode compatibility labels Oct 17, 2022
@lucas-koehler
Copy link
Contributor

I'm having a look at this.

lucas-koehler added a commit to eclipsesource/theia that referenced this issue Jan 10, 2023
@lucas-koehler
vscode: Support isTransient in TerminalOptions and ExtensionTerminalO…
c8d9b25 
…ptions

* Extend `TerminalOptions` and `ExtensionTerminalOptions` with `isTransient` property
  according to the VSCode API
* Add terminal preference `enablePersistentSessions` with default value `true`
* Adhere to pref. `enablePersistentSessions` and option `isTransient` in the terminal widget

Fix eclipse-theia#11777

Contributed on behalf of STMicroelectronics.

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
lucas-koehler added a commit to eclipsesource/theia that referenced this issue Jan 10, 2023
@lucas-koehler
vscode: Support isTransient in TerminalOptions and ExtensionTerminalO…
34b89bd 
…ptions

* Extend `TerminalOptions` and `ExtensionTerminalOptions` with `isTransient` property
  according to the VSCode API
* Add terminal preference `enablePersistentSessions` with default value `true`
* Adhere to pref. `enablePersistentSessions` and option `isTransient` in the terminal widget

Fix eclipse-theia#11777

Contributed on behalf of STMicroelectronics.

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
lucas-koehler added a commit to eclipsesource/theia that referenced this issue Jan 10, 2023
@lucas-koehler
vscode: Support isTransient in TerminalOptions and ExtensionTerminalO…
021539b 
…ptions

* Extend `TerminalOptions` and `ExtensionTerminalOptions` with `isTransient` property
  according to the VSCode API
* Add terminal preference `enablePersistentSessions` with default value `true`
* Adhere to pref. `enablePersistentSessions` and option `isTransient` in the terminal widget

Fix eclipse-theia#11777

Contributed on behalf of STMicroelectronics.

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
lucas-koehler added a commit to eclipsesource/theia that referenced this issue Jan 10, 2023
@lucas-koehler
vscode: Support isTransient in TerminalOptions and ExtensionTerminalO…
7d6af21 
…ptions

* Extend `TerminalOptions` and `ExtensionTerminalOptions` with `isTransient` property
  according to the VSCode API
* Add terminal preference `enablePersistentSessions` with default value `true`
* Adhere to pref. `enablePersistentSessions` and option `isTransient` in the terminal widget

Fix eclipse-theia#11777

Contributed on behalf of STMicroelectronics.

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
@lucas-koehler lucas-koehler mentioned this issue Jan 10, 2023
Merged
1 task
vince-fugnitto pushed a commit that referenced this issue Jan 11, 2023
@lucas-koehler
vscode: Support isTransient in TerminalOptions and ExtensionTerminalO…
73f32f7 
…ptions (#12055)

Fix #11777

* Extend `TerminalOptions` and `ExtensionTerminalOptions` with `isTransient` property
  according to the VSCode API
* Add terminal preference `enablePersistentSessions` with default value `true`
* Adhere to pref. `enablePersistentSessions` and option `isTransient` in the terminal widget

Contributed on behalf of STMicroelectronics.

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucas-koehler lucas-koehler

Labels
terminal issues related to the terminal vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vscode: Support isTransient in TerminalOptions and ExtensionTerminalOptions eclipsesource/theia
3 participants
@rschnekenbu @lucas-koehler @vince-fugnitto