Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui/ux] The tree highlighting differs from VS Code #6919

Closed
kittaakos opened this issue Jan 20, 2020 · 1 comment
Closed

[ui/ux] The tree highlighting differs from VS Code #6919

kittaakos opened this issue Jan 20, 2020 · 1 comment
Labels
good first issue good first issues for new contributors help wanted issues meant to be picked up, require help theming issues related to theming tree issues related to the tree (ex: tree widget) ui/ux issues related to user interface / user experience

Comments

@kittaakos
Copy link
Contributor

Description

Theia uses different styles in the tree than VS Code. Something is odd with the mark style.

VS Code:
Screen Shot 2020-01-20 at 09 36 53

Theia Tree:
Screen Shot 2020-01-20 at 09 40 06

Theia File Dialog:
Screen Shot 2020-01-20 at 09 37 03

API:

/**
* The optional color of the text data that is being highlighted. Falls back to the default `mark` color values defined under a widget segment class.
*/

CSS:

.theia-TreeNodeSegment mark {
background-color: var(--theia-list-filterMatchBackground);
}

TSX:

return <mark className={TreeDecoration.Styles.CAPTION_HIGHLIGHT_CLASS} style={style}>{data}</mark>;

Reproduction Steps

OS and Theia version:

Diagnostics:

@kittaakos kittaakos added tree issues related to the tree (ex: tree widget) ui/ux issues related to user interface / user experience labels Jan 20, 2020
@akosyakov akosyakov added theming issues related to theming help wanted issues meant to be picked up, require help labels Jan 20, 2020
@vince-fugnitto vince-fugnitto added the good first issue good first issues for new contributors label Jan 20, 2020
@justin8502
Copy link
Contributor

Going to take a look at this issue.

akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
- Changed tree.css file to override default mark color (black) with
foreground color (--theia-list-inactiveSelectionForeground).

Signed-off-by: Justin Ang <justinang13@gmail.com>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
- Changed tree.css file to override default mark color (black) with
foreground color (--theia-list-inactiveSelectionForeground).

Signed-off-by: Justin Ang <justinang13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue good first issues for new contributors help wanted issues meant to be picked up, require help theming issues related to theming tree issues related to the tree (ex: tree widget) ui/ux issues related to user interface / user experience
Projects
None yet
Development

No branches or pull requests

4 participants