Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[output] Implement output scroll-lock #7347

Closed
kittaakos opened this issue Mar 16, 2020 · 1 comment · Fixed by #7570
Closed

[output] Implement output scroll-lock #7347

kittaakos opened this issue Mar 16, 2020 · 1 comment · Fixed by #7570
Assignees
@kittaakos
Labels
enhancement issues that are enhancements to current functionality - nice to haves output issues related to the output

Comments

@kittaakos
Copy link
Contributor

Description

It should be possible to lock a channel in the output view. If a channel is locked, incoming messages must not change the selected channel.

Reproduction Steps

OS and Theia version:

Diagnostics:
@kittaakos kittaakos added enhancement issues that are enhancements to current functionality - nice to haves output issues related to the output labels Mar 16, 2020
@akosyakov
Copy link
Member

akosyakov commented Mar 16, 2020 •
edited
Loading

Do you mean something like if don't scroll to the bottom when don't scroll, i.e. you scroll up a bit? But if the last line is visible then scroll?

nvm just seen in VS Code.

@kittaakos kittaakos self-assigned this Apr 9, 2020
kittaakos pushed a commit that referenced this issue Apr 14, 2020
GH-7347: Added scroll-lock to the Output view.
37d0fdd 
Closes #7347.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Apr 14, 2020
GH-7347: Added scroll-lock to the Output view.
6902633 
Closes #7347.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Apr 14, 2020
GH-7347: Added scroll-lock to the Output view.
bbc1e76 
Closes #7347.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Apr 15, 2020
GH-7347: Added scroll-lock to the Output view.
f0c226c 
Closes #7347.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Apr 15, 2020
GH-7347: Added scroll-lock to the Output view.
1ad0c07 
Closes #7347.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Apr 15, 2020
GH-7347: Added scroll-lock to the Output view.
dd3590c 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos mentioned this issue Apr 15, 2020
Merged
1 task
kittaakos pushed a commit that referenced this issue Apr 15, 2020
GH-7347: Added scroll-lock to the Output view.
6b5cf97 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Apr 16, 2020
GH-7347: Added scroll-lock to the Output view.
fe48540 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Apr 16, 2020
GH-7347: Added scroll-lock to the Output view.
3cd6ded 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Apr 16, 2020
GH-7347: Added scroll-lock to the Output view.
085067a 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Apr 18, 2020
GH-7347: Added scroll-lock to the Output view.
90e3bb0 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Apr 23, 2020
GH-7347: Added scroll-lock to the Output view.
9815436 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Apr 30, 2020
GH-7347: Added scroll-lock to the Output view.
f00b151 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue May 18, 2020
GH-7347: Added scroll-lock to the Output view.
c1e7f49 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue May 26, 2020
GH-7347: Added scroll-lock to the Output view.
75318d7 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue May 27, 2020
GH-7347: Added scroll-lock to the Output view.
c924c1e 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue May 27, 2020
GH-7347: Added scroll-lock to the Output view.
5591cad 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue May 27, 2020
GH-7347: Added scroll-lock to the Output view.
262fb06 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Jun 2, 2020
GH-7347: Added scroll-lock to the Output view.
0a25796 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Jun 3, 2020
GH-7347: Added scroll-lock to the Output view.
acb7be7 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Jun 3, 2020
GH-7347: Added scroll-lock to the Output view.
7048b1a 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Jun 3, 2020
@kittaakos
GH-7347: Added scroll-lock to the Output view.
6043722 
Closes #7347.
Closes #7008.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
enhancement issues that are enhancements to current functionality - nice to haves output issues related to the output
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-7347: Added scroll-lock to the Output view eclipse-theia/theia
2 participants
@kittaakos @akosyakov