-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console: do not clear output when a session ends #10671
Conversation
I believe that the motivation behind removing the reference to the debug session was to ensure that it would be garbage-collected when the session was terminated. With this change, that doesn't happen: The |
But if push comes to shove, I think retaining a reference to the session is better than deleting the output, so if there's no way to preserve the output without retaining the reference for now, that's OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better than the alternative for now, though it may be worth making an issue to allow for retention of output when session is set to undefined.
The commit fixes an issue which caused the debug console output to clear when a session was completed. The change now preserves the output so end-users can view the output of their debug session. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
bb99744
to
2fc298d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well. I agree with Colin, we can fix the dangling debug session reference sometime else.
I'll merge for the moment since it improves the behavior for end-users, and open a follow-up issue to track the cleanup. |
What it does
Fixes: #10653.
The pull-request fixes an issue which caused the debug console output to clear when a session was completed.
The change now preserves the output so end-users can view the output of their debug session.
It namely reverts a change proposed in #10333.
How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com