Implement Tree Compression #10713
Merged
Implement Tree Compression #10713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-grant-work
added
navigator
msujew
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
That looks really good! The changes to the tree container construction are done quite well.
- Opening/closing collapsed tree nodes works as expected
- Keyboard navigation for the explorer works just like in VSCode
- Feedback to changing the compact preference is applied instantly
I have a minor suggestion to improve the usability of this feature.
- Implements generic tree services for trees that compress multiple nodes into a row - Converts the FileTree and NavigatorTree to use those services - Refactors the `createTreeContainer` function to reduce boilerplate when creating custom trees Co-authored by: Colin Grant <colin.grant@ericsson.com> Co-authored by: Esther Perelman <esther.perelman@sap.com>
colin-grant-work
force-pushed
the
cjg/tree-compression
branch
from
4e9ef68
to
2b04895
Compare
vince-fugnitto
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
I verified the functionality and confirmed that:
- the behavior is consistent with vscode
- the preference
exploer.compactFoldersworks and is aligned with vscode - performing a search in the explorer works (even better than vscode)
- creating folders simultaneously with the dialog works (folders are created compactly)
- creating a file at a compact folder updates accordingly
- expanding and collapsing folders works well - even collapse all
- navigation of collapsed folders works well with the arrow keys
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #4783
Closes #10268
This implements compact nodes for
TreeNodes with a single child that is also aCompositeTreeNodeand uses those services in theNavigatorTree. It is based mostly on #10268.I also refactored the
createTreeContainermethod to reduce the amount of boilerplate you have to write to set up a custom tree. It's not really necessary, but it does both make it clearer to callers what they get in their container (interfaces define the full service set) and make it easier to override those services.How to test
api-samplesthat has various structures of interest to compression. Open Theia or open that workspace directly.explorer.compactFolderspreference and observe that the tree compresses and uncompresses as expected.Review checklist
Reminder for reviewers