Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: fix debuggingForeground theming #10760

Merged
merged 1 commit into from
Feb 18, 2022
Merged

debug: fix debuggingForeground theming #10760

merged 1 commit into from
Feb 18, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

Closes: #10430.

The pull-request fixes the debuggingForeground theming when a debug session is started and a theme defines a custom foreground color. Previously the custom color would not apply.

How to test

  1. consume https://github.com/vince-fugnitto/vscode-debug-theme/releases/download/v0.0.1/theme-debug-0.0.1.vsix in your application - the extension contributes a theme which sets the foreground color to blue when debugging
  2. start the application
  3. confirm that during a debug session the styling of the toolbar is correct
  4. set the theme to Theme: Debug Test
  5. confirm that during a debug session the foreground color of the statusbar is blue

Review checklist

Reminder for reviewers

@vince-fugnitto @ChayaLau
debug: fix debuggingForeground theming
1af42d2 
The commit fixes the `debuggingForeground` theming when a debug session
is started and a theme defines a custom foreground color. Previously the
custom color would not apply.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Co-authored-by: Chayalau <chaya.lau@sap.com>
@vince-fugnitto vince-fugnitto added theming issues related to theming debug issues that related to debug functionality labels Feb 16, 2022
paul-marechal
paul-marechal approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as described

@paul-marechal paul-marechal merged commit 34e332c into master Feb 18, 2022
@paul-marechal paul-marechal deleted the vf/debuggingForeground branch February 18, 2022 20:49
@github-actions github-actions bot added this to the 1.23.0 milestone Feb 18, 2022
colin-grant-work pushed a commit to colin-grant-work/theia that referenced this pull request Feb 23, 2022
@vince-fugnitto @ChayaLau @colin-grant-work
debug: fix debuggingForeground theming (eclipse-theia#10760)
1c470b1 
The commit fixes the `debuggingForeground` theming when a debug session
is started and a theme defines a custom foreground color. Previously the
custom color would not apply.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Co-authored-by: Chayalau <chaya.lau@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-marechal paul-marechal paul-marechal approved these changes

Assignees
No one assigned
Labels
debug issues that related to debug functionality theming issues related to theming
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vince-fugnitto @paul-marechal