Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open SIW results as previews #10839

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Open SIW results as previews #10839

merged 1 commit into from
Mar 4, 2022

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes #7589, closes #8735.

How to test

  1. Use the Search-in-Workspace widget to perform a search.
  2. Single-click on a result -> should open as preview
  3. Double-click on a result -> should open as full widget
  4. Add a replace term.
  5. Same as 2-3, but with a diff widget.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the search in workspace issues related to the search-in-workspace label Mar 3, 2022
vince-fugnitto
vince-fugnitto approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well for me 👍 I confirmed that:

Use-Case Preference Click Behavior Outcome
Search "editor.enablePreview": true single the editor is correctly opened as a preview
Search "editor.enablePreview": true double the editor is opened normally
Search "editor.enablePreview": false single the editor is opened normally
Search "editor.enablePreview": false double the editor is opened normally
Search & Replace "editor.enablePreview": true single the diff editor is correctly opened as a preview
Search & Replace "editor.enablePreview": true double the diff editor is opened normally
Search & Replace "editor.enablePreview": false single the diff editor is opened normally
Search & Replace "editor.enablePreview": false double the diff editor is opened normally

@colin-grant-work colin-grant-work merged commit 6cdbd4b into eclipse-theia:master Mar 4, 2022
@colin-grant-work colin-grant-work deleted the finish-up/previews-in-SIW branch March 4, 2022 15:50
@colin-grant-work colin-grant-work added this to the 1.24.0 milestone Mar 4, 2022
@vince-fugnitto vince-fugnitto mentioned this pull request May 9, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
search in workspace issues related to the search-in-workspace
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

File search doesn't open files as preview
2 participants
@colin-grant-work @vince-fugnitto