application-manager: fix expose-loader #10845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the loader causes some applications to fail at runtime.
Use an alternative writing for one of the injected string of code.
How to test
Should fix the browser application start failure for this repository:
https://github.com/theia-ide/theia-trace-extension/tree/b4855ec742015d08bbec0d3d549b83eb61df8ec5
Linux-only:
yarn
.yarn download:server
yarn --cwd examples/browser start
localhost:3000
, it should fail because of someReferenceError: global
.node_modules/@theia/application-manager/lib/expose-loader.js
and replace the same string as this PR.yarn --cwd examples/browser
yarn --cwd examples/browser start
localhost:3000
, it should work.Review checklist
Reminder for reviewers