Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach Open Editors after Navigator #10930

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Attach Open Editors after Navigator #10930

merged 1 commit into from
Mar 28, 2022

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes #10928 by adding the open editors widget after the navigator. The order field should ensure that the open editors widget appears before the navigator, and adding it second ensures that it is not automatically expanded as the sole child of the ViewContainer.

How to test

  1. Run Reset Workbench Layout
  2. Open the Navigator view container
  3. Observe that the open editors widget is collapsed and above the navigator tree.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added navigator issues related to the navigator/explorer open-editors issues related to the open-editors view labels Mar 25, 2022
vince-fugnitto
vince-fugnitto approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well for me 👍

msujew
msujew approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, also works well for me 👍

@colin-grant-work colin-grant-work merged commit a8b8bbe into eclipse-theia:master Mar 28, 2022
@colin-grant-work colin-grant-work added this to the 1.24.0 milestone Mar 28, 2022
@colin-grant-work colin-grant-work deleted the bugfix/open-editors-initial-collapse branch March 28, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
navigator issues related to the navigator/explorer open-editors issues related to the open-editors view
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

InitiallyCollasped property isn't working on Open Editors widget
3 participants
@colin-grant-work @msujew @vince-fugnitto