Call onHide
in MonacoContextMenuService
#11152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #11059 by fixing the
MonacoContextMenuService
to callonHide
. Previously, it was returning the callback rather than calling the callback, resulting in this flag never getting reset, pushing us down this code path, resulting in the immediate disposal of any contributed code action items.How to test
yarn browser test
)The test on that branch doesn't work with the version of the TypeScript plugin we currently use - the code actions contributed by TS have a bug - so that branch is rebased on #11083 and uses
vscode.typescript-language-features@1.62.3
. I will make a separate PR for the test that can be merged once this PR and #11083 have been merged.Review checklist
Reminder for reviewers