Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: track ApplicationError codes #11160

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

paul-marechal
Copy link
Member

We don't register new codes.

Properly track defined ApplicationError codes.

How to test

N/A: There is a new test case for it.

Review checklist

Reminder for reviewers

We don't register new codes.

Properly track defined `ApplicationError` codes.
@vince-fugnitto vince-fugnitto added the quality issues related to code and application quality label May 16, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :+1

@paul-marechal paul-marechal merged commit f4aa1b0 into master May 17, 2022
@paul-marechal paul-marechal deleted the mp/application-error-fix branch May 17, 2022 03:06
@github-actions github-actions bot added this to the 1.26.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants