-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move WebviewViewResolveContext to root namespace #11216
Move WebviewViewResolveContext to root namespace #11216
Conversation
Fixes #11149 ? |
Yes 👍 Added it the PR description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that the changes align our type definition to vscode 👍
0ee38e4
to
1fa8f77
Compare
The WebviewViewResolveContext was previously in the window namespace. Removed it in the window namespace and added it to root namespace. Fixes eclipse-theia#11149. Contributed on behalf of STMicroelectronics.
1fa8f77
to
ff3597a
Compare
I rebased and squashed the commits. Can this be merged? |
@sgraband I'll merge this a bit later, when the CI run has finished successfully 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let see if this works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes
What it does
To be compatable with the VSCode API the
WebviewViewResolveContext
needs to be in the root namespace. See here.The WebviewViewResolveContext was previously in the window namespace.
Removed it from the window namespace and added it to root namespace.
Fixes #11149.
Contributed on behalf of STMicroelectronics.
How to test
Review checklist
Reminder for reviewers