Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Output widget from handling any drag/drop events #11275

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes #10932 by preventing the Output widget from interfering in its parent's handling of drag-drop events.

How to test

  1. Try dragging and dropping widgets onto the Output widget.
  2. Observe that the behavior is the same as dragging/dropping on top of other widgets: you can can drop in the middle to put a new widget on the same tabbar, or to one side / top / bottom to split the panel.
  3. Ensure that you don't see the behavior from the second cast here where the Output widget accepts the drop of the new widget as though it were an output channel.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the output issues related to the output label Jun 8, 2022
@colin-grant-work
Copy link
Contributor Author

@kittaakos, I'd be happy to hear your thoughts about this approach.

@kittaakos
Copy link
Contributor

I have checked out the branch and verified the changes locally; I can confirm that it works.

verify_output.mp4

Thank you for the cleanup!

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that dragging widgets over the output view now behaves as expected 👍

@colin-grant-work colin-grant-work merged commit 4e88272 into eclipse-theia:master Jun 9, 2022
@colin-grant-work colin-grant-work deleted the bugfix/drag-drop-over-output branch June 9, 2022 15:00
@colin-grant-work colin-grant-work added this to the 1.27.0 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
output issues related to the output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widget drag-drop fails over Output widget
3 participants