Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix active sidepanel border #11330

Merged
merged 1 commit into from
Jun 27, 2022
Merged

ui: fix active sidepanel border #11330

merged 1 commit into from
Jun 27, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes: #11329.

The pull-request fixes a minor visual bug where the active border for sidepanels moved the icon for the tab.

switch-active.mp4

How to test

  1. start the application
  2. confirm that switching the active tab in the sidepanels (both left and right) does not cause the visual bug where the tab icon is pushed.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added the ui/ux issues related to user interface / user experience label Jun 23, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, that fixes the issue of the icons moving around 👍

However, I see that VSCode actually uses a width of 2px for the sidepanels, so we should probably align. It's currently only a single pixel.

The commit fixes a minor visual bug where the active border for
sidepanels moved the icon for the tab.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto
Copy link
Member Author

However, I see that VSCode actually uses a width of 2px for the sidepanels, so we should probably align. It's currently only a single pixel.

Sound good! I updated to 2px :)

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vince-fugnitto vince-fugnitto merged commit 324aec5 into master Jun 27, 2022
@vince-fugnitto vince-fugnitto deleted the vf/active-sidepanels branch June 27, 2022 14:56
@github-actions github-actions bot added this to the 1.27.0 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: minor visual push for active sidepanel tabs
2 participants