Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser freezing when executing child debug #11388

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

alvsan09
Copy link
Contributor

@alvsan09 alvsan09 commented Jul 5, 2022

What it does

Fixes: #11387

Fixes an infinite loop that was triggered when attempting
to resolve a parent console.

How to test

Copying test procedure from: #9613

  1. Clone this test repo into Theia and make sure the vscode-js-debug extension is installed in Theia.
  2. Start a debugging session with the contained Launch Program configuration.
  3. Child processes will now be shown as a tree in the threads view.
  4. Start a second debugging session with the same configuration
  5. Another tree will appear in the threads view and you can switch between the different debug consoles.

Review checklist

Reminder for reviewers

Fixes an infinite loop that was triggered when attempting
to resolve a parent console.

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
@alvsan09 alvsan09 force-pushed the asl/debugging_children_freezes branch from a52fd57 to 5d7abdf Compare July 5, 2022 23:53
@alvsan09 alvsan09 added the debug issues that related to debug functionality label Jul 5, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I can confirm that the issue exists on master and is addressed by this change nicely 👍

@alvsan09 alvsan09 merged commit c82d9c5 into master Jul 6, 2022
@alvsan09 alvsan09 deleted the asl/debugging_children_freezes branch July 6, 2022 13:20
@github-actions github-actions bot added this to the 1.28.0 milestone Jul 6, 2022
@alvsan09
Copy link
Contributor Author

alvsan09 commented Jul 6, 2022

Thanks! I can confirm that the issue exists on master and is addressed by this change nicely +1

Thanks @msujew !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser freezes when executing child debug sessions
2 participants