Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map 'workbench.action.saveWorkspaceAs' to SAVE_WORKSPACE_AS #11395

Conversation

kaiyue-pan-work
Copy link
Contributor

@kaiyue-pan-work kaiyue-pan-work commented Jul 7, 2022

What it does

Map 'workbench.action.saveWorkspaceAs' to SAVE_WORKSPACE_AS so that it can be used by VS Code extensions.

How to test

  1. Download this sample extension for testing
  2. Build Theia from sources
  3. Create plugins folder under Theia repo folder
  4. Run Theia and click the folder icon in the activity-bar to open the view
  5. Click the small-folder icon in the view to run the command
    image
  6. Confirm that the Save Workspace As... dialog shows up

Review checklist

Reminder for reviewers

Signed-off-by: Kaiyue Pan kaiyue.a.pan@ericsson.com

@colin-grant-work
Copy link
Contributor

@kaiyue-pan-work, it looks like you'll need to (re-)sign the Eclipse ECA for the email address you're using.

@kaiyue-pan-work kaiyue-pan-work force-pushed the save-workspace-as-vscode-commands-contribution branch 2 times, most recently from 56b7373 to bb93304 Compare July 7, 2022 22:51
@kaiyue-pan-work
Copy link
Contributor Author

Thanks @colin-grant-work. I have re-signed the Eclipse ECA using my work email.

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Jul 8, 2022

@kaiyue-pan-work the ECA failure is related to an incorrect authorship email as it is using a no-reply instead of the one used to sign the ECA:

From bb93304e128ac948ede7c4e9588bede437f69f3d Mon Sep 17 00:00:00 2001
From: Kaiyue Pan <94718614+kaiyue-pan-work@users.noreply.github.com>
Date: Thu, 7 Jul 2022 12:04:25 -0500
Subject: [PATCH] Map 'workbench.action.saveWorkspaceAs' to SAVE_WORKSPACE_AS

Signed-off-by: Kaiyue Pan <kaiyue.a.pan@ericsson.com>
---
 .../src/browser/plugin-vscode-commands-contribution.ts         | 3 +++
 1 file changed, 3 insertions(+)

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Jul 8, 2022
Signed-off-by: Kaiyue Pan <kaiyue.a.pan@ericsson.com>
@kaiyue-pan-work kaiyue-pan-work force-pushed the save-workspace-as-vscode-commands-contribution branch from bb93304 to 18961f7 Compare July 8, 2022 15:00
@kaiyue-pan-work
Copy link
Contributor Author

Thanks @vince-fugnitto. I have updated my authorship email and the ECA check looks good now.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, and work well 👍

@vince-fugnitto vince-fugnitto merged commit 3b689e0 into eclipse-theia:master Jul 8, 2022
@vince-fugnitto vince-fugnitto added this to the 1.28.0 milestone Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants