Hide toolbars on inactive tabbars #11480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #9593
Theia displays toolbars on all tabbars in the main area, whether the tabbar is active or not. VSCode only displays the toolbar on the active tabbar. As a consequence, plugin toolbar items can have unexpected effects if the user clicks on toolbar item for an inactive tab. This PR aligns Theia's behavior with VSCode's by hiding toolbars on inactive tabbars.
How to test
Review checklist
Reminder for reviewers