Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map vscode theme icons to codicons #11527

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Aug 4, 2022

What it does

Closes #10746

Maps ThemeIcon IDs to their corresponding codicon. See also here.

How to test

  1. Install the tree-view-sample extension (download)
  2. Open a JSON file (such as the package.json) and open the JSON Outline view
  3. Each node should have a random codicon assigned (none are displayed on master)

Review checklist

Reminder for reviewers

@msujew msujew added the vscode issues related to VSCode compatibility label Aug 4, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool! The changes work well for me 👍

@msujew msujew force-pushed the msujew/vscode-theme-icon-id branch from e67eecd to 1c9e949 Compare August 4, 2022 15:32
@msujew msujew merged commit 5318f1e into master Aug 4, 2022
@msujew msujew deleted the msujew/vscode-theme-icon-id branch August 4, 2022 22:28
@github-actions github-actions bot added this to the 1.29.0 milestone Aug 4, 2022
federicobozzini pushed a commit to ARMmbed/theia that referenced this pull request Oct 13, 2022
federicobozzini pushed a commit to ARMmbed/theia that referenced this pull request Apr 18, 2023
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
erezmus pushed a commit to ARMmbed/theia that referenced this pull request May 11, 2023
Signed-off-by: Federico Bozzini <federico.bozzini@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theia doesn't support VS Code icon identifiers
3 participants