Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12394-12395-12396 Localized some phrases (clipboard, scm, git) #12473

Merged
merged 10 commits into from
Jun 29, 2023

Conversation

Zebsterpasha
Copy link
Contributor

@Zebsterpasha Zebsterpasha commented Apr 28, 2023

What it does

Closes: #12394
Closes: #12395
Closes: #12396

The pull-request adds missing localizations referenced in the issues.

How to test

Just check if keys of localized phrases are correct, i didn't change functional.

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zebsterpasha thank you for the contribution, do you mind fixing the build errors?

packages/core/i18n/nls.ru.json Outdated Show resolved Hide resolved
packages/core/src/browser/browser-clipboard-service.ts Outdated Show resolved Hide resolved
@Zebsterpasha
Copy link
Contributor Author

@vince-fugnitto @msujew Hi) Could you, please, rewiev my request and merge it?)

@Zebsterpasha Zebsterpasha requested a review from msujew June 7, 2023 06:59
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants