Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo, moved generate-layout script #4878

Closed
wants to merge 1 commit into from

Conversation

spoenemann
Copy link
Contributor

The generate-layout script uses Electron and thus should be moved to a package that has a direct dependency to it.

Signed-off-by: Miro Spönemann <miro.spoenemann@typefox.io>
@spoenemann
Copy link
Contributor Author

Open question (copied from #4724):

Should we extract the script to a separate repository to make creating keyboard layouts easier, esp. for external contributors? We don't need to build the whole of Theia just to run a simple NodeJS script.

@akosyakov
Copy link
Member

@spoenemann Together with generated layouts that other can contribute?

@akosyakov
Copy link
Member

The generate-layout script uses Electron and thus should be moved to a package that has a direct dependency to it.

We don't publish generate-layout script layout right now. And electron is always hoisted to root, so yarn can find it from any place in the project. Do you really want to move it?

@spoenemann
Copy link
Contributor Author

Together with generated layouts that other can contribute?

Those need to be in @theia/core so we can use them directly (unless we publish an external package dedicated to this purpose and depend on it).

electron is always hoisted to root

Nevermind then.

@spoenemann spoenemann closed this Apr 11, 2019
@spoenemann spoenemann deleted the msp_move-generate-layout branch April 11, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants