Git diff list uses the perfect scroll bar now. #6085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTugarev
reviewed
Sep 3, 2019
current issues on master:
vs.this PR 🎉
|
AlexTugarev
reviewed
Sep 3, 2019
| } | ||
|
|
||
| focus(): void { | ||
| if (this.listContainer) { | ||
| this.listContainer.focus(); | ||
| } | ||
| } | ||
|
|
||
| getListContainer(): HTMLDivElement | undefined { |
| @@ -67,6 +69,10 @@ export class GitDiffWidget extends GitNavigableListWidget<GitFileChangeNode> imp | |||
| })); | |||
| } | |||
|
|
|||
| protected getScrollContainer(): MaybePromise<HTMLElement> { | |||
| return new Promise(resolve => this.fileChangeListContainerIsReady = resolve); | |||
There was a problem hiding this comment.
please use the Deferred from @theia/core/lib/common/promise-util for such cases
| } | ||
|
|
||
| componentDidUpdate(): void { | ||
| this.props.onListContainerReady(this.listContainer); |
There was a problem hiding this comment.
Q: does it actually change?
| } | ||
| })(); | ||
| } | ||
|
|
||
| protected onResize(msg: Widget.ResizeMessage): void { | ||
| super.onResize(msg); | ||
| this.update(); |
| @@ -413,11 +428,20 @@ export class GitDiffListContainer extends React.Component<GitDiffListContainer.P | |||
|
|
|||
| componentDidMount(): void { | |||
| this.props.addDiffListKeyListeners(this.props.id); | |||
| this.props.onListContainerReady(this.listContainer); | |||
There was a problem hiding this comment.
WDYT of renaming onListContainerReady –> setListContainer? onSomething sounds like an event handler.
|
please get rid of commits fixing issues in the original commit |
jbicker
force-pushed
the
git-diff-perfect-scrollbar
branch
from
beccff1
to
0df0d95
Compare
|
@AlexTugarev and @akosyakov : thanks for reviewing and the hints. |
AlexTugarev
reviewed
Sep 3, 2019
jbicker
force-pushed
the
git-diff-perfect-scrollbar
branch
from
0df0d95
to
bbd36d6
Compare
Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
jbicker
force-pushed
the
git-diff-perfect-scrollbar
branch
from
bbd36d6
to
026fd51
Compare
AlexTugarev
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The ListContainer of the GitDiff View uses the PerfectScrollbar instead of the browser native scrollbar now.
It fixes also an error which caused that sometimes, after resizing vertically, elements at the lower end weren't selectable anymore.
See gitpod-io/gitpod#757
How to test
Use a repository where are enough different files between two branches and use the Git Diff command to open these changes.
The scrollbar of the git diff widget should show the same scrollbar in all browsers.
All elements should be selectable even after resizing.
Review checklist
Reminder for reviewers