[terminal] map localhost to external links

[akosyakov]

What it does

It allows to open localhost links from terminal as external.

Generally we should always use OpenerService to apply complete logic. Don't take shortcuts to concrete handlers or try to implement them using WindowService.

How to test

• for regressions tests that it still works locally
• if possible test in remote environments, but obviously with some changes to ExternalUriService.toRemoteHost
  • for Gitpod:

return `${localhost.port}-${window.location.hostname.substr(window.location.hostname.indexOf('-') + 1)}`;

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

CI is failing due to missing semicolons:

https://travis-ci.com/eclipse-theia/theia/jobs/261647969#L718
https://travis-ci.com/eclipse-theia/theia/jobs/261647969#L719

[akosyakov]

@vince-fugnitto should be fixed now, i've opened a PR from my fork, so there can be some travis issues, like github rate limit

[vince-fugnitto]

@vince-fugnitto should be fixed now, i've opened a PR from my fork, so there can be some travis issues, like github rate limit

It looks like the CI has passed :)
I am however not sure on how to test the functionality or expose the bug on master.

[akosyakov]

@vince-fugnitto:

• Start something on localhost
• Print its address to the terminal with echo
• When you click the page should open.
• Before it will work only if Theia works locally on localhost as well, now given that a product implements ExternalUriService properly the page with the proper external URI should be opened.

[svenefftinge]

LGTM