[keybinding] Align Electron keybindings for 'Open File' and 'Open Workspace Symbol' with VS Code #6690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kspace Symbol' with VS Code Signed-off-by: Jan Keromnes <jan.keromnes@typefox.io>
3 tasks
akosyakov
added
electron
kittaakos
approved these changes
Dec 5, 2019
|
That's awesome, thanks a lot Akos! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #6633.
In browsers, the keybindings remain unchanged:
File>Open...F1>Open Workspace Symbol...However, in Electron the bindings are now aligned with VS Code across all 3 platforms:
File>Open...F1>Open Workspace Symbol...How to test
Open Theia/Electron on Windows, Mac OS and Linux. The
Open FileandOpen Workspace Symbolkeybindings should be the same as VS Code.Review checklist
Reminder for reviewers