Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1614, GH-4532: Various dev experience enhancements for win32 #6893

Merged
merged 3 commits into from
Jan 19, 2020
Merged

GH-1614, GH-4532: Various dev experience enhancements for win32 #6893

merged 3 commits into from
Jan 19, 2020

Commits on Jan 14, 2020

  1. GH-1614: Updated the doc with the Windows steps. 

    Got rid of `choco` and simplified the steps with `scoop`.

The steps now include headless commands for installing the followings:
 - `nvm`,
 - Node.js,
 - `yarn`, and optionally
 - `git`.

Closes #1614

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
    Akos Kitta committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    4d3cc36 View commit details
    Browse the repository at this point in the history

  2. [win]: Fixed the circular dependency exclude path 

    So `webpack` does not try to detect module cycles under `node_modules`.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
    Akos Kitta committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    18bbaa2 View commit details
    Browse the repository at this point in the history

  3. GH-4532: Enabled parallel lerna execution on Win32 

     - Aug 7, 2017: The parallel execution was bugusly introduced: e8beacc.
 - Nov 9, 2018: The logic was fixed: 5a60919.

`lerna` ran perfecetly without the sequential restriction for a year.
No need to punish Windows users with this build penalty.

This commit reverts e8beacc.

Closes #4532

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
    Akos Kitta committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    3d95651 View commit details
    Browse the repository at this point in the history