Mark only those commands ran using quick menu as recent

[dsseng]

What it does

Fixes #7527

How to test

See #7527

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[dsseng]

This probably needs another fix...

[dsseng]

Anything is okay, but originally recent commands got stored, now they don't. I need help from somebody to make it work.

[vince-fugnitto]

@sh7dm you may see the quick poc with minimal changes to achieve the behavior:
https://github.com/eclipse-theia/theia/compare/vf/recent-commands?expand=1

Only commands triggered from the quick-command menu will be registered as recently used, and those triggered from other menus, keybindings, toolbar items will not.

[dsseng]

@vince-fugnitto yes, this's the thing I did in the first commit. The issue was that tests failed, I could fix them but I wasn't sure if it doesn't break anything else. If you're sure it won't, I can restore this solution and make tests pass.

[vince-fugnitto]

@vince-fugnitto yes, this's the thing I did in the first commit. The issue was that tests failed, I could fix them but I wasn't sure if it doesn't break anything else. If you're sure it won't, I can restore this solution and make tests pass.

I see, you can retry, if there are test failures I can see as what the reason may be :)

[dsseng]

@vince-fugnitto here's the test result, I'll restore to that point and fix failing tests.

[vince-fugnitto]

@vince-fugnitto here's the test result, I'll restore to that point and fix failing tests.

The test cases will need to be updated as well:

• https://github.com/eclipse-theia/theia/blob/master/packages/core/src/common/command.spec.ts

---

When verifying test cases you can run:

npx run build @theia/core
npx run test @theia/core

[vince-fugnitto]

Please squash your commits into a single commit and ping me when you're ready for another review :)

[dsseng]

@vince-fugnitto should be OK now, you can review if you don't mind.

[vince-fugnitto]

@sh7dm thank you for your contribution, the changes look good! 👍
We have some more work to do with recent commands, I tested some things on master and subsequently this pull-request and there are still some issues that I'd like resolved.