Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include global tasks in "Configure Tasks" #7929

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

tsmaeder
Copy link
Contributor

Signed-off-by: Thomas Mäder tmader@redhat.com

What it does

Includes tasks from user-level tasks when invoking the "configure tasks" action.
Fixes: Global Tasks not considered in "Configure Tasks..." #7916

How to test

Add some global and some workspace-local tasks and invoke "configure tasks".

Review checklist

Reminder for reviewers

Signed-off-by: Thomas Mäder <tmader@redhat.com>
Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in single and multi root workspaces. it worked as described.

@vince-fugnitto vince-fugnitto added the tasks issues related to the task system label Jun 1, 2020
Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and can confirm that Global tasks are available and displayed for Configure Task action.

@tsmaeder tsmaeder merged commit 3ae0586 into eclipse-theia:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants