Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list onFileSystem activation event as supported #8320

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Aug 6, 2020

What it does

How to test

Review checklist

Reminder for reviewers

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Aug 6, 2020
@AlexTugarev
Copy link
Contributor

@typescript-eslint/eslint-plugin cannot be found, i.e. the build is broken. 'will revisit later.

Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akosyakov
Tested for master branch and current PR branch, can confirm, that

  • for master branch I can see:
    unsupported_git
    at adding git built-in extension

  • I don't see such log using current PR changes

  • I still see the notification:

activating_git_error

But I guess it's OK for current PR and according to the PR description will be fixed within #8318

@akosyakov akosyakov merged commit 8005222 into master Aug 6, 2020
@akosyakov akosyakov deleted the akosyakov/unsupported-activation-8319 branch August 6, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported activation events: onFileSystem:git
3 participants