Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsx-registry: fix the search query based on the search parameters #8607

Merged
merged 1 commit into from
Oct 8, 2020
Merged

vsx-registry: fix the search query based on the search parameters #8607

merged 1 commit into from
Oct 8, 2020

Conversation

vince-fugnitto
Copy link
Member

What it does

The following pull-request fixes the open-vsx search query which was previously incorrectly built when providing multiple search parameters.

  • fixes the search query to support multiple search parameters.
  • adds unit tests for the building of the search query.
  • adds support for additional search parameters (sortBy, sortOrder, and includeAllVersions).

How to test

  • the CI should successfully pass (build and test of the newly added unit test file).
  • the functionality should work as before:
    • start the application, and navigate to the extensions view
    • search for an extension (it should yield results like on master)

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added bug bugs found in the application vsx-registry Issues related to Open VSX Registry Integration labels Oct 8, 2020
@vince-fugnitto vince-fugnitto self-assigned this Oct 8, 2020
@vince-fugnitto
vsx: fix search query
9d2d1ba 
The following commit fixes the `open-vsx` search query:
- fixes the `search` query when multiple search parameters are used.
- adds a test to verify the search query.
- adds support for additional search parameters (`sortOrder`, `sortBy`,
  and `includeAllVersions`).

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
paul-marechal
paul-marechal approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vince-fugnitto vince-fugnitto merged commit fd7d9d2 into master Oct 8, 2020
@vince-fugnitto vince-fugnitto deleted the vf/vsx-query branch October 8, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-marechal paul-marechal paul-marechal approved these changes

Assignees

@vince-fugnitto vince-fugnitto

Labels
bug bugs found in the application vsx-registry Issues related to Open VSX Registry Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vince-fugnitto @paul-marechal