ci: Build using C99 and C11 #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rettichschnidi
force-pushed
the
gardena/rs/c-standards
branch
3 times, most recently
from
a94a2b8
to
09cb33e
Compare
|
@qleisan Added some description about how to test the PR. |
qleisan
approved these changes
Apr 6, 2021
It's integrated. :-) |
rettichschnidi
force-pushed
the
gardena/rs/c-standards
branch
from
09cb33e
to
cfb25f5
Compare
|
Should I wait action was no more stuck on queued state before to integrate this in master ? |
I think so, yes. While like to have stuff merged quickly, we should not merge anything that has not passed all tests IMHO. |
rettichschnidi
force-pushed
the
gardena/rs/c-standards
branch
from
cfb25f5
to
43fa4cd
Compare
While we do not have any non-GNU-compatible compilers in CI, disabling compiler extensions and enabling -pedantic should help us to keep specific compiler extensions at bay. Because this code base is still quite POSIX dependent, _POSIX_C_SOURCE is defined manually. Signed-off-by: Reto Schneider <code@reto-schneider.ch>
rettichschnidi
force-pushed
the
gardena/rs/c-standards
branch
from
43fa4cd
to
2f6d699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the code base is still sprinkled with POSIX dependencies, this PR ensures the following:
When reviewing, this should give you a couple of warnings (same as in master), but otherwise work:
Using this new version of run_ci.sh and the code from the current master, all builds with disabled extensions fail and the C99 ones throw additional warnings.