Block wise transfer tests #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LukasWoodtli You will need to sign the Eclipse contributor agreement and rebase on the most recent master commit to fix the builds. |
rettichschnidi
changed the title
LukasWoodtli
force-pushed
the
gardena/lw/block-wise-transfer-tests
branch
4 times, most recently
from
e86865f
to
5329f0f
Compare
rettichschnidi
requested changes
Mar 1, 2023
There was a problem hiding this comment.
Regarding commit messages:
- I think there is some mix-up as the last commit clearly adds new code, not refactoring existing one as its description says.
- I think this finally resolves block transfer unit tests broken #511, yay! Would mention this in the body of the first commit (which is not just refactoring)
Comment on lines
+101
to
+115
| } | ||
| static void test_block1_same_message_after_success(void) { |
There was a problem hiding this comment.
Missing newline
Suggested change
| } | |
| static void test_block1_same_message_after_success(void) { | |
| } | |
| static void test_block1_same_message_after_success(void) { |
LukasWoodtli
force-pushed
the
gardena/lw/block-wise-transfer-tests
branch
3 times, most recently
from
406dcb3
to
fcd721e
Compare
The input buffer for the block handling functions is never modified. Therefore it can be provided as an constant pointer to the corresponding functions.
The tests are more modular and more readable now. This fixes eclipse-wakaama#511.
This thest is a simple usecase with multiple block2 transfers to send a big message.
LukasWoodtli
force-pushed
the
gardena/lw/block-wise-transfer-tests
branch
from
fcd721e
to
66f1145
Compare
The test sends the same meassage twice. The message is split into blocks.
LukasWoodtli
force-pushed
the
gardena/lw/block-wise-transfer-tests
branch
from
66f1145
to
52b24f1
Compare
rettichschnidi
approved these changes
Mar 11, 2023
|
|
||
| static void test_block2_receive_simple_GET(void) { | ||
| lwm2m_block_data_t *blk = NULL; | ||
| /* This should be incremented for each block. But it leads to a COAP_408_REQ_ENTITY_INCOMPLETE. */ |
There was a problem hiding this comment.
This is a bug then in the existing implementation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some unit tests were refactored and improved.
Added also some new tests.