Fixing feature build #419
Merged
Fixing feature build #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ip validation is failing as the commit needs to be signed. Can you please sign it? I'll merge and create a milestone. |
Signed-off-by: Zoltan Ujhelyi <ujhelyiz@incquerylabs.com>
ujhelyiz
force-pushed
the
feature-repository-fix
branch
from
faf466b
to
eb797d2
Compare
|
Sorry for the trouble; I have replaced the contribution with a signed version. |
|
No worries, thanks for fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #383 introduced a separate build to provide Eclipse features to the Photon Simultaneous Release repository; however, it incorrectly referenced the original parent instead of being entirely standalone.
This change fixes the issue by removing the parent declaration from the p2-feature module.