Remove spring REST doc #1446
Merged
Remove spring REST doc #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Since now hawkBit support Swagger and OpenAPI the documentation is built using redoc based on OpenAPI definitions. Spring REST documentation is not needed anymore. Since this Spring REST doc is not needed and it duplicates API documentation (no single source of truth and hard to maintain) with this commit it is removed. Some tests from the Spring REST doc that seems are not covered by the JUnit of the resource modules are moved in the resource JUnit tests. Signed-off-by: Marinov Avgustin <Avgustin.Marinov@bosch.com>
avgustinmm
force-pushed
the
remove_rest_doc
branch
from
d221554
to
57cdfca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since now hawkBit support Swagger and OpenAPI the documentation is built using redoc based on OpenAPI definitions. Spring REST documentation is not needed anymore.
Since this Spring REST doc is not needed and it duplicates API documentation (no single source of truth and hard to maintain) with this commit it is removed.
Some tests from the Spring REST doc that seems are not covered by the JUnit of the resource modules are moved in the resource JUnit tests.