Blank editor after formatting source code via LS #902
Comments
ghentschke
added a commit
to ghentschke/lsp4e-bachmann-fixes
that referenced
this issue
Jan 27, 2024
Splitting \r\n line endings leads to a BadLocationException while TextViewer.setRedraw is executed during a document.replace operation triggered by a TextEdit. fixes eclipse#902
ghentschke
added a commit
to ghentschke/lsp4e-bachmann-fixes
that referenced
this issue
Jan 28, 2024
Adds unit test to validate change. fixes eclipse#902
ghentschke
added a commit
to ghentschke/lsp4e-bachmann-fixes
that referenced
this issue
Jan 28, 2024
Add check in case that end line from edit is larger than the documents number of lines. fixes eclipse#902
mickaelistria
pushed a commit
that referenced
this issue
Jan 29, 2024
Splitting \r\n line endings leads to a BadLocationException while TextViewer.setRedraw is executed during a document.replace operation triggered by a TextEdit. fixes #902
mickaelistria
pushed a commit
that referenced
this issue
Jan 29, 2024
Adds unit test to validate change. fixes #902
mickaelistria
pushed a commit
that referenced
this issue
Jan 29, 2024
Add check in case that end line from edit is larger than the documents number of lines. fixes #902
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When formatting a source code file in the editor, the editor can become blank caused by a
BadLocationExceptionduringTextViewer.setRedraw. See this cdt-lsp issue for further detailsAfter some investigation I found out that it will be triggered, when the
TextEditresponse on atextDocument/formattingrequest leads to a splitting of the\r\nline ending. See this comment.This could be fixed in
org.eclipse.lsp4e.LSPEclipseUtils.applyEdits(IDocument, List<? extends TextEdit>). I can provide a PR for that.The text was updated successfully, but these errors were encountered: