-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle resource instances in Read, Write, and Observe. #435
Handle resource instances in Read, Write, and Observe. #435
Conversation
09e9ede
to
792847e
Compare
Rebased. I didn't think squashing made sense. @rettichschnidi please review. |
#496 fixes the location of tinydtls, but there is another build problem. I'll rebase again once the build is fixed. |
Signed-off-by: Scott Bertin <sbertin@telular.com>
Signed-off-by: Scott Bertin <sbertin@telular.com>
Fix problem serializing resource instance reads. Fix handling of empty strings and opaque. Fix JSON serializing single instance resource as multiple. Fixes eclipse-wakaama#378. Fix JSON parsing of multiple instance resources. Fixes eclipse-wakaama#399. Signed-off-by: Scott Bertin <sbertin@telular.com>
Signed-off-by: Scott Bertin <sbertin@telular.com>
Signed-off-by: Scott Bertin <sbertin@telular.com>
Fixes eclipse-wakaama#332 and prepares for writes of individual resource instances. Signed-off-by: Scott Bertin <sbertin@telular.com>
Signed-off-by: Scott Bertin <sbertin@telular.com>
Signed-off-by: Scott Bertin <sbertin@telular.com>
792847e
to
68b6c49
Compare
Rebased again. |
@sbertin-telular I am busy with other stuff right now, but @qleisan committed to give feedback. |
I have reviewed the commits and "looks good to me". However I can only do a "lighter review" at this time since I'm still getting into the project/codebase. |
I suppose this means that I can integrate those commits ? (or there are more review planned ?) |
In my opinion yes. @sbertin-telular, ok for you? |
@sbernard31 go ahead and merge. |
Done. @sbertin-telular, regarding your comment :
Should we close #396 ? |
@sbernard31 Yes, I think we should close #396. |
@sbertin-telular and #437 too ? (regarding #437 (comment)) |
Yes, #437 too. |
Implements partial updates in writes as that was needed to handle the resource instances without major API changes.
Also fixes several issues found that impacted implementation and/or testing.
Contains an alternate fix to #396.