This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
[eclipse/xtext#1777] ported xtend code 2 java #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kthoms
reviewed
Jul 17, 2020
org.eclipse.xtext.xbase.testing/src/org/eclipse/xtext/xbase/testing/InMemoryJavaCompiler.java
Outdated
Show resolved
Hide resolved
kthoms
reviewed
Jul 17, 2020
| cache.put(fileName, null); | ||
| return null; | ||
| } | ||
| ClassFileReader reader = ClassFileReader.read(url.openStream(), fileName); |
There was a problem hiding this comment.
use try-with-resources for url.openStream()?
There was a problem hiding this comment.
try (InputStream is = url.openStream()) {
ClassFileReader reader = ClassFileReader.read(is, fileName);
NameEnvironmentAnswer result = new NameEnvironmentAnswer(reader, null);
cache.put(fileName, result);
return result;
}
kthoms
reviewed
Jul 17, 2020
org.eclipse.xtext.xbase.testing/src/org/eclipse/xtext/xbase/testing/InMemoryJavaCompiler.java
Outdated
Show resolved
Hide resolved
kthoms
reviewed
Jul 17, 2020
org.eclipse.xtext.xbase.testing/src/org/eclipse/xtext/xbase/testing/InMemoryJavaCompiler.java
Show resolved
Hide resolved
kthoms
reviewed
Jul 17, 2020
org.eclipse.xtext.xbase.testing/src/org/eclipse/xtext/xbase/testing/InMemoryJavaCompiler.java
Outdated
Show resolved
Hide resolved
kthoms
reviewed
Jul 17, 2020
org.eclipse.xtext.xbase.testing/src/org/eclipse/xtext/xbase/testing/InMemoryJavaCompiler.java
Outdated
Show resolved
Hide resolved
kthoms
reviewed
Jul 17, 2020
org.eclipse.xtext.xbase.testing/src/org/eclipse/xtext/xbase/testing/InMemoryJavaCompiler.java
Outdated
Show resolved
Hide resolved
cdietrich
force-pushed
the
cd_testingX2j
branch
2 times, most recently
from
8b10fd1
to
e8f0a42
Compare
kthoms
reviewed
Jul 17, 2020
| ListExtensions.map(Arrays.asList(sources), | ||
| (JavaSource it) -> new CompilationUnit(it.getCode().toCharArray(), it.getFileName(), null)), | ||
| ICompilationUnit.class)); | ||
| compiler.compile(units); |
There was a problem hiding this comment.
refactor to:
ICompilationUnit[] units = Stream.of(sources).map(it -> new CompilationUnit(it.getCode().toCharArray(), it.getFileName(), null)).toArray(ICompilationUnit[]::new);
There was a problem hiding this comment.
this is not about refactoring everything
There was a problem hiding this comment.
The current code is way more hard to read. Above statement does the same.
Comment on lines
+100
to
+104
| message.append("PROBLEMS : "); | ||
| message.newLine(); | ||
| message.append("\t"); | ||
| message.append(Joiner.on("\n").join(result.getCompilationProblems()), "\t"); | ||
| message.newLineIfNotEmpty(); |
There was a problem hiding this comment.
extract to method, sequence is used twice
Comment on lines
+73
to
+77
| message.append("Java code compiled with errors:"); | ||
| message.newLine(); | ||
| message.append(Joiner.on("\n").join( | ||
| Iterables.filter(result.getCompilationProblems(), CategorizedProblem::isError))); | ||
| message.newLineIfNotEmpty(); |
There was a problem hiding this comment.
extract to method, sequence is used twice
Comment on lines
+176
to
+178
| sourceCode.append("public class __Generated implements org.eclipse.xtext.xbase.lib.Functions.Function0<"); | ||
| sourceCode.append(returnType.getName()); | ||
| sourceCode.append("> {"); |
There was a problem hiding this comment.
This may read better with
sourceCode.append(String.format("public class __Generated implements org.eclipse.xtext.xbase.lib.Functions.Function0<%s> {", returnType.getName())
If you agree there are other line candidates.
cdietrich
force-pushed
the
cd_testingX2j
branch
3 times, most recently
from
8b15a76
to
a515e57
Compare
|
ping @kthoms @szarnekow |
Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
szarnekow
approved these changes
Jul 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[eclipse/xtext#1777] ported xtend code 2 java
Signed-off-by: Christian Dietrich christian.dietrich@itemis.de