Remove incorrect usage of expect.toBeDefined

ecraig12345 · Oct 22, 2020 · 19ec826 · 19ec826
1 parent 0014d1f
commit 19ec826
Show file tree

Hide file tree

Showing 23 changed files with 79 additions and 96 deletions.
diff --git a/packages/date-time/src/components/DatePicker/DatePicker.test.tsx b/packages/date-time/src/components/DatePicker/DatePicker.test.tsx
@@ -97,7 +97,7 @@ describe('DatePicker', () => {
     const datePicker = mount(<DatePickerBase isRequired={true} allowTextInput={true} onSelectDate={onSelectDate} />);
     const textField = datePicker.find('input');
 
-    expect(textField).toBeDefined();
+    expect(textField).toHaveLength(1);
 
     textField.simulate('change', { target: { value: 'Jan 1 2030' } }).simulate('blur');
     textField.simulate('change', { target: { value: '' } }).simulate('blur');

diff --git a/packages/react-experiments/src/components/SelectedItemsList/SelectedItemsList.test.tsx b/packages/react-experiments/src/components/SelectedItemsList/SelectedItemsList.test.tsx
@@ -41,7 +41,7 @@ describe('SelectedItemsList', () => {
           ]}
         />,
       );
-      expect(wrapper).toBeDefined();
+      expect(wrapper.exists()).toBeTruthy();
       expect(wrapper.find('div').length).toEqual(3);
       expect(
         wrapper
@@ -75,7 +75,7 @@ describe('SelectedItemsList', () => {
         onItemsRemoved={removeItems}
       />,
     );
-    expect(wrapper).toBeDefined();
+    expect(wrapper.exists()).toBeTruthy();
     expect(wrapper.find('div').length).toEqual(3);
     expect(
       wrapper
@@ -102,7 +102,7 @@ describe('SelectedItemsList', () => {
         ]}
       />,
     );
-    expect(wrapper).toBeDefined();
+    expect(wrapper.exists()).toBeTruthy();
     expect(wrapper.find('div').length).toEqual(3);
     expect(
       wrapper

diff --git a/packages/react-internal/src/compat/components/Button/Button.test.tsx b/packages/react-internal/src/compat/components/Button/Button.test.tsx
@@ -208,10 +208,8 @@ describe('Button', () => {
         expect(button.getAttribute('aria-label')).toBeNull();
 
         expect(button.getAttribute('aria-labelledby')).toEqual(button.querySelector(`.ms-Button-label`)!.id);
-        expect(button.getAttribute('aria-labelledby')).toBeDefined();
 
         expect(button.getAttribute('aria-describedby')).toEqual(button.querySelector('.some-screenreader-class')!.id);
-        expect(button.getAttribute('aria-describedby')).toBeDefined();
       });
 
       it('applies aria-describedby to an IconButton', () => {
@@ -226,10 +224,8 @@ describe('Button', () => {
         expect(button.getAttribute('aria-label')).toBeNull();
 
         expect(button.getAttribute('aria-labelledby')).toBeNull();
-        expect(button.getAttribute('aria-labelledby')).toBeDefined();
 
         expect(button.getAttribute('aria-describedby')).toEqual(button.querySelector('.some-screenreader-class')!.id);
-        expect(button.getAttribute('aria-describedby')).toBeDefined();
       });
 
       it('applies aria-labelledby and aria-describedby to a CompoundButton with ariaDescription', () => {
@@ -246,10 +242,8 @@ describe('Button', () => {
         expect(button.getAttribute('aria-label')).toBeNull();
 
         expect(button.getAttribute('aria-labelledby')).toEqual(button.querySelector('.ms-Button-label')!.id);
-        expect(button.getAttribute('aria-labelledby')).toBeDefined();
 
         expect(button.getAttribute('aria-describedby')).toEqual(button.querySelector('.some-screenreader-class')!.id);
-        expect(button.getAttribute('aria-describedby')).toBeDefined();
       });
 
       it(
@@ -263,10 +257,8 @@ describe('Button', () => {
           expect(button.getAttribute('aria-label')).toBeNull();
 
           expect(button.getAttribute('aria-labelledby')).toEqual(button.querySelector('.ms-Button-label')!.id);
-          expect(button.getAttribute('aria-labelledby')).toBeDefined();
 
           expect(button.getAttribute('aria-describedby')).toEqual(button.querySelector('.ms-Button-description')!.id);
-          expect(button.getAttribute('aria-describedby')).toBeDefined();
         },
       );
 
@@ -983,15 +975,14 @@ describe('Button', () => {
 
         const button = render(element);
 
-        expect(button).toBeDefined();
         ReactTestUtils.Simulate.click(button);
 
         // get the menu id from the button's aria attribute
         const menuId = button.getAttribute('aria-owns');
-        expect(menuId).toBeDefined();
+        expect(menuId).toBeTruthy();
 
         const menuDOM = button.ownerDocument!.getElementById(menuId as string);
-        expect(menuDOM).toBeDefined();
+        expect(menuDOM).toBeTruthy();
 
         return menuDOM as HTMLElement;
       }
@@ -1001,7 +992,7 @@ describe('Button', () => {
 
         expect(contextualMenuElement).not.toBeNull();
         expect(contextualMenuElement.getAttribute('aria-label')).toBeNull();
-        expect(contextualMenuElement.getAttribute('aria-labelledBy')).toBeDefined();
+        expect(contextualMenuElement.getAttribute('aria-labelledBy')).toBeTruthy();
       });
 
       it('If button has a text child, contextual menu has aria-labelledBy attribute set', () => {
@@ -1048,12 +1039,11 @@ describe('Button', () => {
 
         const button = render(element);
 
-        expect(button).toBeDefined();
         ReactTestUtils.Simulate.click(button);
 
         // get the menu id from the button's aria attribute
         const menuId = button.getAttribute('aria-owns');
-        expect(menuId).toBeDefined();
+        expect(menuId).toBeTruthy();
 
         const contextualMenuElement = button.ownerDocument!.getElementById(menuId as string);
         expect(contextualMenuElement).not.toBeNull();

diff --git a/packages/react-internal/src/components/Calendar/Calendar.test.tsx b/packages/react-internal/src/components/Calendar/Calendar.test.tsx
@@ -85,7 +85,6 @@ describe('Calendar', () => {
         renderedComponent,
         'ms-DatePicker-monthAndYear',
       );
-      expect(dayPickerMonth).toBeDefined();
       expect(dayPickerMonth.textContent).toEqual(monthName + ' ' + year.toString());
     });
 
@@ -118,7 +117,6 @@ describe('Calendar', () => {
 
     it('Verify go to today', () => {
       const goToToday = ReactTestUtils.findRenderedDOMComponentWithClass(renderedComponent, 'ms-DatePicker-goToday');
-      expect(goToToday).toBeDefined();
       expect(goToToday.textContent).toEqual(dayPickerStrings.goToToday);
     });
   });
@@ -156,7 +154,6 @@ describe('Calendar', () => {
         renderedComponent,
         'ms-DatePicker-monthAndYear',
       );
-      expect(dayPickerMonth).toBeDefined();
       expect(dayPickerMonth.textContent).toEqual(monthName + ' ' + defaultDate.getFullYear().toString());
     });
 
@@ -182,7 +179,6 @@ describe('Calendar', () => {
         renderedComponent,
         'ms-DatePicker-monthPicker',
       ) as HTMLElement;
-      expect(monthPicker).toBeDefined();
       expect(monthPicker.style.display).not.toEqual('none');
     });
 
@@ -191,7 +187,6 @@ describe('Calendar', () => {
         renderedComponent,
         'ms-DatePicker-currentYear',
       );
-      expect(currentYear).toBeDefined();
       expect(currentYear.textContent).toEqual(defaultDate.getFullYear().toString());
     });
 
@@ -205,7 +200,6 @@ describe('Calendar', () => {
 
     it('Verify go to today', () => {
       const goToToday = ReactTestUtils.findRenderedDOMComponentWithClass(renderedComponent, 'ms-DatePicker-goToday');
-      expect(goToToday).toBeDefined();
       expect(goToToday.textContent).toEqual(dayPickerStrings.goToToday);
     });
 
@@ -232,11 +226,9 @@ describe('Calendar', () => {
 
     it('Verify class name', () => {
       const calendarRoot = ReactTestUtils.scryRenderedDOMComponentsWithClass(renderedComponent, 'CalendarTestClass');
-      expect(calendarRoot).toBeDefined();
-      expect(calendarRoot.length).toEqual(1);
+      expect(calendarRoot).toHaveLength(1);
       const root = calendarRoot[0];
-      expect(root.classList).toBeDefined();
-      expect(root.classList.length).toEqual(2);
+      expect(root.classList).toHaveLength(2);
       expect(root.classList[0]).toEqual('ms-DatePicker');
       expect(root.classList[1]).toEqual('CalendarTestClass');
     });

diff --git a/packages/react-internal/src/components/ChoiceGroup/ChoiceGroup.test.tsx b/packages/react-internal/src/components/ChoiceGroup/ChoiceGroup.test.tsx
@@ -53,7 +53,7 @@ describe('ChoiceGroup', () => {
   it('does not use className prop from parent on label', () => {
     choiceGroup = mount(<ChoiceGroup className="testClassName" label="test label" options={TEST_OPTIONS} required />);
     const label = choiceGroup.getDOMNode().querySelector('label');
-    expect(label).toBeDefined();
+    expect(label).toBeTruthy();
     expect(label!.textContent).toBe('test label');
     expect(label!.className).not.toContain('testClassName');
   });

diff --git a/packages/react-internal/src/components/ColorPicker/ColorRectangle/ColorRectangle.test.tsx b/packages/react-internal/src/components/ColorPicker/ColorRectangle/ColorRectangle.test.tsx
@@ -71,7 +71,7 @@ describe('ColorRectangle', () => {
     const descriptionId = element.getAttribute('aria-describedby');
     expect(descriptionId).toBeTruthy();
     const descriptionEl = element.querySelectorAll('#' + descriptionId)[0];
-    expect(descriptionEl).toBeDefined();
+    expect(descriptionEl).toBeTruthy();
     expect(descriptionEl.textContent).toBe(
       'Use left and right arrow keys to set saturation. Use up and down arrow keys to set brightness.',
     );

diff --git a/packages/react-internal/src/components/CommandBar/CommandBar.deprecated.test.tsx b/packages/react-internal/src/components/CommandBar/CommandBar.deprecated.test.tsx
@@ -58,7 +58,7 @@ describe('CommandBar', () => {
 
     menuItem.simulate('click');
 
-    expect(document.querySelector('.SubMenuClass')).toBeDefined();
+    expect(document.querySelector('.SubMenuClass')).toBeTruthy();
   });
 
   it('keeps menu open after update if item is still present', () => {
@@ -87,7 +87,7 @@ describe('CommandBar', () => {
     menuItem.simulate('click');
 
     // Make sure the menu is open before the re-render
-    expect(document.querySelector('.SubMenuClass')).toBeDefined();
+    expect(document.querySelector('.SubMenuClass')).toBeTruthy();
 
     // Update the props, and re-render
     commandBar.setProps({
@@ -100,7 +100,7 @@ describe('CommandBar', () => {
     });
 
     // Make sure the menu is still open after the re-render
-    expect(document.querySelector('.SubMenuClass')).toBeDefined();
+    expect(document.querySelector('.SubMenuClass')).toBeTruthy();
   });
 
   it('closes menu after update if item is not longer present', () => {
@@ -129,7 +129,7 @@ describe('CommandBar', () => {
     menuItem.simulate('click');
 
     // Make sure the menu is open before the re-render
-    expect(document.querySelector('.SubMenuClass')).toBeDefined();
+    expect(document.querySelector('.SubMenuClass')).toBeTruthy();
 
     // Update the props, and re-render
     commandBar.setProps({
@@ -164,7 +164,7 @@ describe('CommandBar', () => {
     menuItem.simulate('click');
 
     // Make sure the menu is open before the re-render
-    expect(document.querySelector('.SubMenuClass')).toBeDefined();
+    expect(document.querySelector('.SubMenuClass')).toBeTruthy();
 
     // Update the props
     items[0].subMenuProps.items[0].className = 'SubMenuClassUpdate';
@@ -175,6 +175,6 @@ describe('CommandBar', () => {
     });
 
     // Make sure the menu is still open after the re-render
-    expect(document.querySelector('.SubMenuClassUpdate')).toBeDefined();
+    expect(document.querySelector('.SubMenuClassUpdate')).toBeTruthy();
   });
 });
diff --git a/packages/react-internal/src/components/CommandBar/CommandBar.test.tsx b/packages/react-internal/src/components/CommandBar/CommandBar.test.tsx
@@ -84,7 +84,7 @@ describe('CommandBar', () => {
 
     menuItem.simulate('click');
 
-    expect(document.querySelector('.SubMenuClass')).toBeDefined();
+    expect(document.querySelector('.SubMenuClass')).toBeTruthy();
   });
 
   it('passes event and item to button onClick callbacks', () => {
@@ -137,7 +137,7 @@ describe('CommandBar', () => {
     menuItem.simulate('click');
 
     // Make sure the menu is open before the re-render
-    expect(document.querySelector('.SubMenuClass')).toBeDefined();
+    expect(document.querySelector('.SubMenuClass')).toBeTruthy();
 
     // Update the props, and re-render
     commandBar.setProps({
@@ -150,7 +150,7 @@ describe('CommandBar', () => {
     });
 
     // Make sure the menu is still open after the re-render
-    expect(document.querySelector('.SubMenuClass')).toBeDefined();
+    expect(document.querySelector('.SubMenuClass')).toBeTruthy();
   });
 
   it('closes menu after update if item is not longer present', () => {
@@ -179,7 +179,7 @@ describe('CommandBar', () => {
     menuItem.simulate('click');
 
     // Make sure the menu is open before the re-render
-    expect(document.querySelector('.SubMenuClass')).toBeDefined();
+    expect(document.querySelector('.SubMenuClass')).toBeTruthy();
 
     // Update the props, and re-render
     commandBar.setProps({
@@ -254,7 +254,7 @@ describe('CommandBar', () => {
     menuItem.simulate('click');
 
     // Make sure the menu is open before the re-render
-    expect(document.querySelector('.SubMenuClass')).toBeDefined();
+    expect(document.querySelector('.SubMenuClass')).toBeTruthy();
 
     // Update the props
     items[0].subMenuProps.items[0].className = 'SubMenuClassUpdate';
@@ -265,6 +265,6 @@ describe('CommandBar', () => {
     });
 
     // Make sure the menu is still open after the re-render
-    expect(document.querySelector('.SubMenuClassUpdate')).toBeDefined();
+    expect(document.querySelector('.SubMenuClassUpdate')).toBeTruthy();
   });
 });
diff --git a/packages/react-internal/src/components/ContextualMenu/ContextualMenu.deprecated.test.tsx b/packages/react-internal/src/components/ContextualMenu/ContextualMenu.deprecated.test.tsx
@@ -73,11 +73,11 @@ describe('ContextualMenu', () => {
     const header = document.querySelector('.headerFoo') as HTMLElement;
     const title = document.querySelector('.titleFoo') as HTMLElement;
 
-    expect(container).toBeDefined();
-    expect(rootEl).toBeDefined();
-    expect(list).toBeDefined();
-    expect(header).toBeDefined();
-    expect(title).toBeDefined();
+    expect(container).toBeTruthy();
+    expect(rootEl).toBeTruthy();
+    expect(list).toBeTruthy();
+    expect(header).toBeTruthy();
+    expect(title).toBeTruthy();
   });
 
   it('applies in-line style property if present on ContextualMenuItem', () => {
@@ -260,7 +260,7 @@ describe('ContextualMenu', () => {
       ReactTestUtils.Simulate.keyDown(menuItem, { which: KeyCodes.right });
     });
 
-    expect(document.querySelector('.SubMenuClass')).toBeDefined();
+    expect(document.querySelector('.SubMenuClass')).toBeTruthy();
   });
 });
 
@@ -291,7 +291,7 @@ describe('getItemClassNames', () => {
       iconClassName,
     );
 
-    expect(itemClassNames).toBeDefined();
+    expect(itemClassNames).toBeTruthy();
   });
 
   it('applies custom classNames to style slots', () => {