Popup: Fix memory leak due to element reference in callback closure (m…

…icrosoft#11619) * Popup: Fix disposables and element ref memory leaks * Change files * Dispose Async and add comment * Minimize change-set * Remove unnecessary newline
ecraig12345 · Jan 8, 2020 · ddd6da4 · ddd6da4
1 parent d641984
commit ddd6da4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/change/office-ui-fabric-react-2020-01-06-17-26-42-keco-popup-leak.json b/change/office-ui-fabric-react-2020-01-06-17-26-42-keco-popup-leak.json
@@ -0,0 +1,8 @@
+{
+  "type": "patch",
+  "comment": "Popup: Fix disposables and element ref memory leaks",
+  "packageName": "office-ui-fabric-react",
+  "email": "KevinTCoughlin@users.noreply.github.com",
+  "commit": "721006ed4c2f5f95e8d2f126d2e79a03af2f02a8",
+  "date": "2020-01-07T01:26:42.776Z"
+}
diff --git a/packages/office-ui-fabric-react/src/components/Popup/Popup.tsx b/packages/office-ui-fabric-react/src/components/Popup/Popup.tsx
@@ -66,6 +66,9 @@ export class Popup extends React.Component<IPopupProps, IPopupState> {
         this._originalFocusedElement.focus();
       }
     }
+
+    // De-reference DOM Node to avoid retainment via transpiled closure of _onKeyDown
+    delete this._originalFocusedElement;
   }
 
   public render(): JSX.Element {