Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "deps: update rules_oci to 1.4.2" #2618

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Nov 20, 2023

Reverts #2616

The change breaks building the CLI for windows.
See bazel-contrib/rules_oci#420 for the upstream issue.

@malt3 malt3 requested a review from derpsteb November 20, 2023 15:06
@malt3 malt3 requested a review from 3u13r as a code owner November 20, 2023 15:06
Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 622b71a
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/655b75de8b9efc00081f0db9

Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malt3 malt3 merged commit 73eba88 into main Nov 20, 2023
5 checks passed
@malt3 malt3 deleted the revert-2616-deps/bazel/rules_oci_1_4_2 branch November 20, 2023 15:18
@malt3 malt3 added the no changelog Change won't be listed in release changelog label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants