This repository has been archived by the owner on Dec 19, 2022. It is now read-only.
Add snap packaging of device-grove-c #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
anonymouse64
force-pushed
the
feature/snap
branch
from
777bc2e
to
fb20b64
Compare
|
Triggered the snap verify jobs and updated the PR description. This PR is now ready for review/merging |
SteveOss
reviewed
Jun 27, 2019
Previously, this would fail in a clean ubuntu 18.04 instance with: [100%] Linking C executable device-grove /usr/bin/ld: CMakeFiles/device-grove.dir/main.c.o: undefined reference to symbol 'sem_post@@GLIBC_2.2.5' /lib/x86_64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status This is the simplest way to link to pthreads from this project without digging into the c-sdk, etc. Also set the c standard to c99 in a more portable way by setting CMAKE_C_STANDARD. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
* Add an install hook to copy the configuration file and default device profile from read-only $SNAP into $SNAP_DATA for use from the service. This is so users can modify the configuration.toml file and device profile easily * Build the device-sdk-c from source on the edinburgh branch * Use sed to modify the hostname for EdgeX services as localhost by default * Patch libmraa using the patch in this repo before building it * Stage all of the source files from iotech-c-utils and tomlc99 into $SNAPCRAFT_STAGE, then copy from there to the src directory of device-sdk-c before building device-sdk-c to handle the deps. This mirrors what the upstream build.sh script does as close as possible. * Use environment variables for the options to launch device-grove due to https://bugs.launchpad.net/snapd/+bug/1827392 because we can't have "=" in the snap command specification Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
anonymouse64
force-pushed
the
feature/snap
branch
from
fb20b64
to
64b6da3
Compare
|
@SteveOss okay, updated both things |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a snap of (currently Fuji since it's the master branch) device-grove-c.
This PR is currently a draft to setup the branches so we can test the jobs in the sandbox and get the jobs setup in Jenkins on ci-mangement
Fixes: #11
ci-management PR here has been merged: edgexfoundry/ci-management#433
This PR is now ready for review.
To test this snap, on an Raspberry Pi 3B+ that is running an arm64 image, such as what you get by following the setup instructions for the ubuntu server 18.04.2 found here, do the following to build and install the snap:
snapcraftandlxdwithsnap install snapcraft --classicand by following the instructions here for lxdsnapcraft --use-lxd.edgexfoundrysnap from theedinburgh/betachannel withsnap install edgexfoundry --channel=edinburgh/beta- note you should do this first so that the EdgeX services are available when device-grove starts up after being install in the next stepedgex-device-grove*.snap, install this snap withsnap install --dangerous edgex-device-grove*.snapAssuming all of the above works, the snap is installed and the things to check are:
[ ] the daemon in the snap starts up, check with
snap services edgex-device-groveall services listed there should beactiveandenabled[ ] the daemon loads the default Grove_Device.yaml file from
/var/snap/edgex-device-grove/current/config/device-grove/profiles/Grove_Device.yamlinto core-metadata, etc.[ ] the configuration.toml file doesn't contain any references to the revision, i.e. all paths under
/var/snap/edgex-device-grove/start withcurrentas in/var/snap/edgex-device-grove/current/...and not/var/snap/edgex-device-grove/x1/...Additionally, if you have access to the grove sensors, try loading some of the device profiles from
/snap/edgex-device-grove/current/config/edgex-device-grove/res/example-profilesand make sure that curl commands produce correct output. I don't have access to any grove sensors so unfortunately I was unable to do this, but since it's basically the same code as the docker container it should work the same I think.You can see logs from the daemon with
snap logs -f -n=all edgex-device-groveorjournalctl -ef -u snap.edgex-device-grove.*