Skip to content
This repository has been archived by the owner on Dec 19, 2022. It is now read-only.

Device Grove - V2 API changes for 1.2.0 #39

Merged
merged 4 commits into from
Jun 18, 2020

Conversation

BinduRao2018
Copy link
Contributor

No description provided.

Signed-off-by: br <bindu@iotechsys.com>
Signed-off-by: br <bindu@iotechsys.com>
Signed-off-by: br <bindu@iotechsys.com>
Copy link
Member

@iain-anderson iain-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When processing the config, use iot_data_string_map_get_string rather than iterating the map
In the get and put handlers, when returning false, also set the exception so that an error message is passed back in the http reply

Signed-off-by: br <bindu@iotechsys.com>
@BinduRao2018
Copy link
Contributor Author

Incorporated review comments

Copy link
Member

@iain-anderson iain-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iain-anderson iain-anderson merged commit bbc6909 into edgexfoundry:master Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants