Skip to content
This repository has been archived by the owner on Dec 19, 2022. It is now read-only.

fix: local snap development #46

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

bill-mahoney
Copy link
Member

Signed-off-by: Bill Mahoney bill.mahoney@intel.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Without VERSION file, snap building fails locally. Jenkins provides VERSION file in pipeline, but usually unavailable locally.

Issue Number:
edgexfoundry/edgex-global-pipelines#182

What is the new behavior?

if no VERSION file found, snap will use 'local-dev' to allow local building of snap.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

Are there any specific instructions or things that should be known prior to reviewing?

For testing,

cd device-grove-c
docker run --rm -u 0:0 --privileged -v $PWD:/build -w /build -e http_proxy -e https_proxy -e JOB_TYPE -e SNAP_REVISION='' -e SNAP_CHANNEL='latest/edge' -e SNAP_NAME='test' nexus3.edgexfoundry.org:10003/edgex-devops/edgex-snap-builder:latest

Other information

Signed-off-by: Bill Mahoney <bill.mahoney@intel.com>
@bill-mahoney bill-mahoney self-assigned this Sep 9, 2020
@bill-mahoney bill-mahoney added the 1-low priority denoting isolated changes label Sep 9, 2020
@bill-mahoney bill-mahoney added this to the Hanoi milestone Sep 9, 2020
@bill-mahoney bill-mahoney marked this pull request as ready for review September 9, 2020 22:56
Copy link
Contributor

@ernestojeda ernestojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernestojeda ernestojeda merged commit dda3783 into edgexfoundry:master Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1-low priority denoting isolated changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants