Skip to content
This repository has been archived by the owner on Dec 19, 2022. It is now read-only.

build: fix VERSION copy after removal from repo #47

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

ernestojeda
Copy link
Contributor

After the removal of the VERSION file from the repo, the local docker build command started failing. This PR writes the VERSION file on the fly to the docker image using the new make version target.

Signed-off-by: Ernesto Ojeda ernesto.ojeda@intel.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number:

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

Are there any specific instructions or things that should be known prior to reviewing?

Other information

Signed-off-by: Ernesto Ojeda <ernesto.ojeda@intel.com>
Copy link
Member

@bill-mahoney bill-mahoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernestojeda ernestojeda merged commit 7e7a308 into edgexfoundry:master Sep 15, 2020
@ernestojeda ernestojeda deleted the fix-local-version branch September 15, 2020 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants