This repository has been archived by the owner on Dec 19, 2022. It is now read-only.
DSR-1416: Fix to create VERSION file and handle docker build from command line #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: br <bindu@iotechsys.com>
Signed-off-by: br <bindu@iotechsys.com>
Signed-off-by: br <bindu@iotechsys.com>
iain-anderson
suggested changes
Oct 1, 2020
README.md
Outdated
| @@ -19,6 +19,7 @@ The repository can be found on git at [libmraa](https://github.com/intel-iot-dev | |||
| 2. Build a docker image by using the following command | |||
| ``` | |||
| sh> cd device-grove-c | |||
| sh> make version | |||
| sh> docker build . -t < device-grove-c > -f ./scripts/Dockerfile.alpine-3.11 | |||
There was a problem hiding this comment.
should the docker build line not read simply
sh> docker build . -t device-grove-c -f ./scripts/Dockerfile.alpine-3.11
There was a problem hiding this comment.
<> - This is to indicate the image name can be anything and not fixed to device-grove-c. I can remove if it is not clear.
There was a problem hiding this comment.
Yes please, maybe just say underneath "replacing device-grove-c with your preferred image name if necessary" or something
Signed-off-by: br <bindu@iotechsys.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In the current version, the VERSION file required by dockerfile isn't generated properly. This results in failure during initialization when the device service is started
Issue Number:
What is the new behavior?
Updated Makefile to generate VERSION file, to use it in Dockerfile to build docker images locally.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
-NA-
Are there any specific instructions or things that should be known prior to reviewing?
No
Other information