Skip to content
This repository has been archived by the owner on Dec 19, 2022. It is now read-only.

DSR-1416: Makefile update to build docker image #49

Merged
merged 6 commits into from
Oct 5, 2020

Conversation

BinduRao2018
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • [x ] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

make docker on cmd line doesn't work

Issue Number:

What is the new behavior?

Fix added to build docker image from the cmd line using Makefile

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

-NA-

Are there any specific instructions or things that should be known prior to reviewing?

-NA-

Other information

Signed-off-by: br <bindu@iotechsys.com>
Signed-off-by: br <bindu@iotechsys.com>
Signed-off-by: br <bindu@iotechsys.com>
Signed-off-by: br <bindu@iotechsys.com>
…DSR-1416-branch

Signed-off-by: br <bindu@iotechsys.com>
Copy link
Member

@iain-anderson iain-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iain-anderson iain-anderson merged commit a2aaf4b into master Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants