This repository has been archived by the owner on Dec 19, 2022. It is now read-only.
fix(snap): Update dependencies and versioning #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes two build issues with the snap. 1) Source tags for iotech-c-utils and device-sdk-c updated to the latest version. Also update the source tag for mraa to use the long git commit hash instead of the short hash. 2) A VERSION file is required by the cmake build so it is created if it doesn't exist. Snap versioning was also updated to use "snapcraftctl set-version" and to not use the git tag or date in the version string. Signed-off-by: Siggi Skulason <siggi.skulason@canonical.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two build issues with the snap.
Source tags for iotech-c-utils and device-sdk-c updated
to the latest version. Also update the source tag for mraa
to use the long git commit hash instead of the short hash.
A VERSION file is required by the cmake build so it is
created if it doesn't exist.
Snap versioning was also updated to use "snapcraftctl set-version"
and to not use the git tag or date in the version string.
Signed-off-by: Siggi Skulason siggi.skulason@canonical.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The snap doesn't build successfully
Issue Number:
What is the new behavior?
The snap build succeeds
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
Are there any specific instructions or things that should be known prior to reviewing?
Other information